Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix data race that may cause panic and concurrency request limit bug #1219

Merged
merged 1 commit into from
Apr 2, 2024
Merged

*: fix data race that may cause panic and concurrency request limit bug #1219

merged 1 commit into from
Apr 2, 2024

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Mar 13, 2024 •
edited
Loading

@crazycs520 crazycs520 mentioned this pull request Mar 13, 2024
Merged
13 tasks
@crazycs520 crazycs520 changed the title [WIP]fix bug about enable-forwarding and concurrency request limit *: fix issue that no available connections cause by concurrency request limit bug Mar 14, 2024
@crazycs520 crazycs520 mentioned this pull request Mar 14, 2024
Merged
@crazycs520 crazycs520 changed the title *: fix issue that no available connections cause by concurrency request limit bug *: fix data race that no available connections cause by concurrency request limit bug Mar 15, 2024
@crazycs520 crazycs520 changed the title *: fix data race that no available connections cause by concurrency request limit bug *: fix data race that may cause no available connections and panic Mar 15, 2024
@crazycs520 crazycs520 changed the title *: fix data race that may cause no available connections and panic *: fix data race that may cause panic and concurrency request limit bug Mar 15, 2024
zyguan
zyguan approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@zyguan zyguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/client/client_batch.go Outdated Show resolved Hide resolved
cfzjywxk
cfzjywxk reviewed Apr 1, 2024
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other possible risks of incompatiblity bettween the newly introduced limiter and batch client?

internal/client/client_batch.go Outdated Show resolved Hide resolved
internal/client/client_batch.go Outdated Show resolved Hide resolved
@crazycs520
Copy link
Contributor Author

Any other possible risks of incompatiblity bettween the newly introduced limiter and batch client?

I haven't found any other problems yet.

@crazycs520
Copy link
Contributor Author

/merge

@cfzjywxk cfzjywxk merged commit 125a140 into tikv:master Apr 2, 2024
10 checks passed
@crazycs520 crazycs520 deleted the fix-forwaeding-bug branch April 2, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufferflies bufferflies bufferflies approved these changes

@you06 you06 you06 approved these changes

@zyguan zyguan zyguan approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client_batch have race when enable-forwarding is true
5 participants
@crazycs520 @cfzjywxk @zyguan @you06 @bufferflies