Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: increase batch split region limit #254

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jul 27, 2021

Signed-off-by: nolouch [email protected]

What problem does this PR solve?

Ref: pingcap/tidb#22969
Problem Summary:
Splitting and Scattering at the same time will cause multiple conflicts on the same region.
image

What is changed and how it works?

How it Works: increase the split regions' limit in 4.0.

Check List

Tests

  • Make the time consuming of split table more stable
I have run multiple times  to split 4000 regions, and the time is stale about `1m30s`
split single sql result: [map[SCATTER_FINISH_RATIO:1 TOTAL_SPLIT_REGION:2001]]
split all sql run total cost: 1m28.908304306s
split all sql run success!!!

Release note

  • Increasing the split region limit makes the split table and pre split more stable

@nolouch nolouch requested a review from disksing July 27, 2021 10:16
@disksing disksing enabled auto-merge (squash) July 27, 2021 10:53
@disksing disksing merged commit 1279692 into tikv:master Jul 27, 2021
@nolouch nolouch deleted the batch-size branch July 27, 2021 11:06
daimashusheng pushed a commit to daimashusheng/client-go that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants