Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement the external timestamp client #610

Merged
merged 2 commits into from
Oct 31, 2022
Merged

implement the external timestamp client #610

merged 2 commits into from
Oct 31, 2022

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Oct 26, 2022 •
edited
Loading

Signed-off-by: YangKeao [email protected]

This PR also upgrades the integration test to 1.19, as TiDB cannot compile under 1.18.

@YangKeao YangKeao force-pushed the external-timestamp-read branch 9 times, most recently from 14dee9b to 17cca1f Compare October 26, 2022 12:14
lhy1024
lhy1024 reviewed Oct 26, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
internal/mockstore/mocktikv/pd.go Outdated Show resolved Hide resolved
oracle/oracles/local_external_timestamp.go Show resolved Hide resolved
@YangKeao YangKeao force-pushed the external-timestamp-read branch 2 times, most recently from 8dd3be2 to 8ee24cb Compare October 27, 2022 05:56
This was referenced Oct 27, 2022
Merged
Closed
@YangKeao YangKeao force-pushed the external-timestamp-read branch 4 times, most recently from a39f93a to 3d74b59 Compare October 31, 2022 03:32
YangKeao
YangKeao commented Oct 31, 2022
View reviewed changes
integration_tests/go.mod

replace (
github.com/pingcap/tidb v1.1.0-beta.0.20220902042024-0482b2e83ed2 => github.com/YangKeao/tidb v1.1.0-beta.0.20221027084838-c574366d0e5a
github.com/pingcap/tidb/parser v0.0.0-20220724090709-5484002f1963 => github.com/YangKeao/tidb/parser v0.0.0-20221027084838-c574366d0e5a
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will be removed after merging the pingcap/tidb#38689

@sticnarf
Copy link
Collaborator

The version policy of client-go is supporting the oldest version under official maintanence. I'm afraid we should stick to 1.18 at present.

The uber atomic can be an alternative right now.

@YangKeao
Copy link
Member Author

The version policy of client-go is supporting the oldest version under official maintanence. I'm afraid we should stick to 1.18 at present.

The uber atomic can be an alternative right now.

Thanks for the information. I could use uber atomic for implementation and unit test. For integration test, I have to upgrade it to 1.19, as TiDB cannot compile under 1.18 now 🤔 .

@YangKeao
Copy link
Member Author

The version policy of client-go is supporting the oldest version under official maintanence. I'm afraid we should stick to 1.18 at present.

The uber atomic can be an alternative right now.

Fixed. PTAL @sticnarf

@sticnarf
Copy link
Collaborator

Thanks for the information. I could use uber atomic for implementation and unit test. For integration test, I have to upgrade it to 1.19, as TiDB cannot compile under 1.18 now .

Yep, it's okay. Only the main lib needs to compile on 1.18.

@disksing disksing merged commit 30e803b into tikv:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YangKeao @sticnarf @lhy1024 @disksing