Fix incorrect insertion behavior in aggressive locking mode and add tests #651
+388
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
…nges Signed-off-by: MyonKeminta <[email protected]>
12 tasks
Signed-off-by: MyonKeminta <[email protected]>
hawkingrei
pushed a commit
to hawkingrei/client-go
that referenced
this pull request
Feb 24, 2023
…ests (tikv#651) * Add more tests and fix the bug of insert in aggressive locking Signed-off-by: MyonKeminta <[email protected]> * Fix tests Signed-off-by: MyonKeminta <[email protected]> * Fix insert test Signed-off-by: MyonKeminta <[email protected]> * Avoid primary re-selecting in TestAggressiveLockingLoadValueOptionChanges Signed-off-by: MyonKeminta <[email protected]> * Address comments Signed-off-by: MyonKeminta <[email protected]> Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that when inserting on a key that's locked during the previous aggressive locking stage, it may not check the key's existence correctly. Also added more test cases to cover more cornercases of aggressive locking.
Ref: tikv/tikv#13298