-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lock_resolver: handle pessimistic locks in BatchResolveLocks #779
lock_resolver: handle pessimistic locks in BatchResolveLocks #779
Conversation
Signed-off-by: MyonKeminta <[email protected]>
…turn lock type Signed-off-by: MyonKeminta <[email protected]>
txnkv/txnlock/lock_resolver.go
Outdated
@@ -238,11 +238,27 @@ func (lr *LockResolver) BatchResolveLocks(bo *retry.Backoffer, locks []*Lock, lo | |||
txnInfos := make(map[uint64]uint64) | |||
startTime := time.Now() | |||
for _, l := range expiredLocks { | |||
logutil.Logger(bo.GetCtx()).Info("BatchResolveLocks handling lock", zap.Stringer("lock", l)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use logutil.Debug(...)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry. I added this when debugging and forgot to remove it. Keep it as a debug-level log might be a good idea.
Signed-off-by: MyonKeminta <[email protected]>
…ch-resolve-lock-handle-pessimistic-lock
Oops something went wrong about the tests... I'll figure it out when I have time.. |
fixed in #794 |
Ref: pingcap/tidb#43243