Use a new way to create client for v2 #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
disksing
approved these changes
May 18, 2023
iosmanthus
reviewed
May 18, 2023
| @@ -260,6 +260,34 @@ func NewPDClient(pdAddrs []string) (pd.Client, error) { | |||
| return pdCli, nil | |||
| } | |||
|
|
|||
| // NewPDClientWithAPIContext returns an unwrapped pd client with API context. | |||
| func NewPDClientWithAPIContext(pdAddrs []string, apiContext pd.APIContext) (pd.Client, error) { | |||
There was a problem hiding this comment.
How about implementing NewPDClient with NewPDClientWithAPIContext by passing the APIV1 context?
Signed-off-by: Ryan Leung <[email protected]>
iosmanthus
approved these changes
May 18, 2023
iosmanthus
pushed a commit
to iosmanthus/client-go
that referenced
this pull request
Dec 21, 2023
Signed-off-by: iosmanthus <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
Signed-off-by: iosmanthus <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
Signed-off-by: iosmanthus <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
Signed-off-by: iosmanthus <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
Signed-off-by: iosmanthus <[email protected]> Signed-off-by: zzm <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Mar 13, 2024
Signed-off-by: iosmanthus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.