(6.5) lock_resolver: support verifying primary for check_txn_status (#777) #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MyonKeminta <[email protected]>
* support verifying primary for check_txn_status Signed-off-by: MyonKeminta <[email protected]> * update kvproto Signed-off-by: MyonKeminta <[email protected]> * add more failpoint usages Signed-off-by: MyonKeminta <[email protected]> * update depencency and fix test Signed-off-by: MyonKeminta <[email protected]> * Do not skip for unistore; refine logs Signed-off-by: MyonKeminta <[email protected]> * Address comments Signed-off-by: MyonKeminta <[email protected]> --------- Signed-off-by: MyonKeminta <[email protected]> Co-authored-by: MyonKeminta <[email protected]>
|
How can I run CI on this branch? |
Signed-off-by: MyonKeminta <[email protected]>
ekexium
approved these changes
May 29, 2023
MyonKeminta
force-pushed
the
m/cherry-pick-primary-chagne-fix
branch
from
17396b4
to
7a6ed8d
Compare
Signed-off-by: MyonKeminta <[email protected]>
This reverts commit 7a6ed8d. Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: MyonKeminta <[email protected]>
|
Some test fails. Integration tests with tikv fails because there are no nightly build of tikv on release-6.5 branch on dockerhub. golangci fails due to some reason I don't know. But they are not requried by tidb-6.5 branch of this repo so it doesn't block merging. @cfzjywxk PTAL. |
|
Ok we could merge it directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #777 to tidb-6.5 branch.
Ref: pingcap/tidb#42937