Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: add replica number #823

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented May 31, 2023

No description provided.

@disksing
Copy link
Collaborator

need to upgrade pd before merge.

Signed-off-by: nolouch <[email protected]>
Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM!

@@ -110,6 +110,23 @@ func (c *pdClient) GetTS(context.Context) (int64, int64, error) {
return tsMu.physicalTS, tsMu.logicalTS, nil
}

// GetMinTS returns the minimal ts.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe no need to add this line.

@disksing disksing merged commit 27d0c27 into tikv:master Jun 1, 2023
@nolouch nolouch deleted the replica-number branch June 1, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants