reload region cache when store is resolved from invalid status (#843) #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cannot build. |
|
Hold this PR because it may spawns too many goroutines. |
|
See the discussions in #843.
|
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: Smityz <[email protected]> Co-authored-by: disksing <[email protected]> Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Signed-off-by: disksing <[email protected]> Signed-off-by: you06 <[email protected]>
you06
force-pushed
the
tidb-6.5-stale-patch
branch
from
d8bd792
to
3b066b5
Compare
cfzjywxk
reviewed
Jun 27, 2023
| mockRequestLiveness atomic.Value | ||
| } | ||
|
|
||
| regionsNeedReload struct { |
There was a problem hiding this comment.
How about using a channel so Mutex could be saved and operations on the RegionCache are already synchronized?
There was a problem hiding this comment.
A channel is bounded, if it's full when trying scheduling a region to it, it'll wait(maybe the asyncCheckAndResolveLoop is doing something and cannot pull the channel immediately).
crazycs520
reviewed
Jun 27, 2023
crazycs520
reviewed
Jun 27, 2023
crazycs520
reviewed
Jun 27, 2023
crazycs520
reviewed
Jun 27, 2023
internal/locate/region_cache.go
Outdated
Comment on lines
485
to
488
| for regionID := range c.regionsNeedReload.toReload { | ||
| c.reloadRegion(regionID) | ||
| delete(c.regionsNeedReload.toReload, regionID) | ||
| } |
There was a problem hiding this comment.
Look like those codes should be put after line #498 ?
There was a problem hiding this comment.
Delay the reload to next loop which avoids some errors and backoffs, see the comment of Line491 to Line494
Co-authored-by: crazycs <[email protected]> Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
you06
force-pushed
the
tidb-6.5-stale-patch
branch
from
3d629f8
to
98e21b3
Compare
Signed-off-by: you06 <[email protected]>
cfzjywxk
approved these changes
Jun 28, 2023
| @@ -1300,7 +1359,7 @@ func (c *RegionCache) removeVersionFromCache(oldVer RegionVerID, regionID uint64 | |||
|
|
|||
| // insertRegionToCache tries to insert the Region to cache. | |||
| // It should be protected by c.mu.Lock(). | |||
| func (c *RegionCache) insertRegionToCache(cachedRegion *Region) { | |||
| func (c *RegionCache) insertRegionToCache(cachedRegion *Region, invalidateOldRegion bool) { | |||
There was a problem hiding this comment.
Need to comment about the new parameter.
|
What's wrong with golangci-lint 🤔️ |
|
@crazycs520 @ekexium @zyguan |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #843 to tidb-6.5.