Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: try follower when stale read request timeout #969

Merged
merged 9 commits into from
Sep 15, 2023

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Sep 12, 2023

close #970

Do the same test in #970

Before this PR

The following are related metrics, some of metrics here are not as expected:

  • Too much failed query in TiDB 192.168.78.2, which cause by execution timeout.
image image image image

This PR

  • TiDB 192.168.78.2 doesn't have any failed query which execution timeout now, and doesn't have backoff too.
  • TIDB 192.168.78.2 has a low QPS because each of the stale-read queries will timeout (100ms) first and then retry to succeed, and it only has 15 connections executing requests.
image image image image image

@crazycs520 crazycs520 marked this pull request as ready for review September 12, 2023 06:06
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfzjywxk cfzjywxk merged commit 001735b into tikv:master Sep 15, 2023
10 checks passed
@crazycs520 crazycs520 deleted the stale-read-timeout branch September 15, 2023 04:54
crazycs520 added a commit to crazycs520/client-go that referenced this pull request Sep 15, 2023
you06 pushed a commit that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stale read QPS is too low when test with kv_read_timeout and max_execution_time
4 participants