Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate file in the shade jar #712

Open
jiaminglu opened this issue Jan 12, 2023 · 1 comment
Open

Duplicate file in the shade jar #712

jiaminglu opened this issue Jan 12, 2023 · 1 comment
Labels
type/bug Something isn't working

Comments

@jiaminglu
Copy link
Contributor

jiaminglu commented Jan 12, 2023

Bug Report

1. Describe the bug

There are duplicate files in the shade jar. If I unzip the tikv-client-java-3.3.0-SNAPSHOT.jar, there will be a promt:
replace META-INF/LICENSE? [y]es, [n]o, [A]ll, [N]one, [r]ename:.

I am tring to include tikv java client in my project's jar package, and in the gradle task, I cannot exclude the duplicated file, and after some debugging, I found out the duplicate file is in the jar itself. The Jar task of gradle will expand the jar archive before processing, and there is an error

2. Minimal reproduce step (Required)

  1. Package the shade jar
  2. Unzip it to some empty directory

3. What did you see instead (Required)

replace META-INF/LICENSE? [y]es, [n]o, [A]ll, [N]one, [r]ename:.

4. What did you expect to see? (Required)

Unzip success.

5. What are your Java Client and TiKV versions? (Required)

Latest master branch.
The version of TiKV is inrelevant because this is a bug of the packaging process.

@jiaminglu jiaminglu added the type/bug Something isn't working label Jan 12, 2023
@jiaminglu jiaminglu changed the title Duplicate file in the Duplicate file in the shade jar Jan 12, 2023
@jiaminglu
Copy link
Contributor Author

There is a LICENSE file and a license directory. I believe this is caused by the case insensitivity of mac file system, and the shade plugin compare file names case sensitively

jiaminglu pushed a commit to jiaminglu/client-java that referenced this issue Jan 12, 2023
jiaminglu pushed a commit to jiaminglu/client-java that referenced this issue Jan 12, 2023
jiaminglu pushed a commit to jiaminglu/client-java that referenced this issue Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant