Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #774] Add TwoPhaseCommitter new Constructor contains executorService(#774) #775

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

jackjeyis
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #issue_number

Problem Description: TBD

What is changed and how does it work?

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • NO side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • NO related changes

@@ -101,6 +101,21 @@ public TwoPhaseCommitter(TiSession session, long startTime, long lockTTL) {
createExecutorService(WRITE_BUFFER_SIZE));
}

public TwoPhaseCommitter(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change previous constructor method to this(session,startTime,lockTTL,createExecutorService(WRITE_BUFFER_SIZE));
image

@shiyuhang0
Copy link
Collaborator

Please fix DCO by

  1. In your local branch, run: git rebase HEAD~2 --signoff
  2. Force push your changes to overwrite the branch: git push --force-with-lease origin feature/2pc

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.65%. Comparing base (ca8a622) to head (877ab03).

Current head 877ab03 differs from pull request most recent head 40ec78d

Please upload reports for the commit 40ec78d to get more accurate results.

Files Patch % Lines
src/main/java/org/tikv/txn/TwoPhaseCommitter.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #775      +/-   ##
============================================
- Coverage     34.81%   34.65%   -0.16%     
+ Complexity     1355     1345      -10     
============================================
  Files           266      266              
  Lines         14283    14285       +2     
  Branches       1606     1606              
============================================
- Hits           4972     4950      -22     
- Misses         8875     8891      +16     
- Partials        436      444       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiyuhang0 shiyuhang0 changed the title add TwoPhaseCommitter new Constructor contains executorService(#774) [close #774] Add TwoPhaseCommitter new Constructor contains executorService(#774) Jun 3, 2024
@shiyuhang0
Copy link
Collaborator

Tests have passed, they failed in the upload coverage step. merge this PR first and I will open a new PR to fix this problem

@shiyuhang0 shiyuhang0 merged commit 700fad0 into tikv:master Jun 4, 2024
5 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants