-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #774] Add TwoPhaseCommitter new Constructor contains executorService(#774) #775
Conversation
@@ -101,6 +101,21 @@ public TwoPhaseCommitter(TiSession session, long startTime, long lockTTL) { | |||
createExecutorService(WRITE_BUFFER_SIZE)); | |||
} | |||
|
|||
public TwoPhaseCommitter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix DCO by
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #775 +/- ##
============================================
- Coverage 34.81% 34.65% -0.16%
+ Complexity 1355 1345 -10
============================================
Files 266 266
Lines 14283 14285 +2
Branches 1606 1606
============================================
- Hits 4972 4950 -22
- Misses 8875 8891 +16
- Partials 436 444 +8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: b.tian <[email protected]>
Signed-off-by: b.tian <[email protected]>
Signed-off-by: b.tian <[email protected]>
Tests have passed, they failed in the |
What problem does this PR solve?
Issue Number: close #issue_number
Problem Description: TBD
What is changed and how does it work?
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes