-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vote: kennytm as TiKV committer #139
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Neil Shen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (non-binding). @kennytm well deserved!
+1 for this |
Signed-off-by: tison <[email protected]>
@overvenus you may also update the membership file, see also 0953957 @skyzh thanks for your participant. You may directly use approval button rather than leave comment. Though both count effectively :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions!
Signed-off-by: tison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 binding
Thanks for your contributions!
LGTM |
Thanks for your participant in this thread. I think committees don't inherit the right as team maintainers. So as you're listed as tikv team committer, this vote is non-binding. |
lgtm |
@lonng: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Oops, Good to know more about governance in practice:) |
Signed-off-by: tison <[email protected]>
@skyzh with 2 binding votes, we can accept this nomination. Would you mind to help on merging this PR? |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4f80e79
|
GitHub Team membership updated. Congrats @kennytm! |
vote: kennytm as TiKV committer