Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: kennytm as TiKV committer #139

Merged
merged 4 commits into from
Aug 17, 2021
Merged

vote: kennytm as TiKV committer #139

merged 4 commits into from
Aug 17, 2021

Conversation

overvenus
Copy link
Member

vote: kennytm as TiKV committer

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (non-binding). @kennytm well deserved!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2021
@skyzh
Copy link
Member

skyzh commented Aug 13, 2021

+1 for this

Signed-off-by: tison <[email protected]>
@tisonkun
Copy link
Contributor

tisonkun commented Aug 16, 2021

@overvenus you may also update the membership file, see also 0953957

@skyzh thanks for your participant. You may directly use approval button rather than leave comment. Though both count effectively :P

Copy link
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions!

Copy link
Member

@sunxiaoguang sunxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 binding

Thanks for your contributions!

@sunxiaoguang
Copy link
Member

LGTM

@tisonkun
Copy link
Contributor

+1 binding

Thanks for your contributions!

Thanks for your participant in this thread.

I think committees don't inherit the right as team maintainers. So as you're listed as tikv team committer, this vote is non-binding.

@lonng
Copy link
Member

lonng commented Aug 16, 2021

lgtm

@ti-chi-bot
Copy link
Member

@lonng: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sunxiaoguang
Copy link
Member

+1 binding
Thanks for your contributions!

Thanks for your participant in this thread.

I think committees don't inherit the right as team maintainers. So as you're listed as tikv team committer, this vote is non-binding.

Oops, Good to know more about governance in practice:)

@tisonkun
Copy link
Contributor

@skyzh with 2 binding votes, we can accept this nomination. Would you mind to help on merging this PR?

@skyzh
Copy link
Member

skyzh commented Aug 17, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4f80e79

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 17, 2021
@skyzh skyzh merged commit 23b3cf9 into tikv:master Aug 17, 2021
@tisonkun
Copy link
Contributor

GitHub Team membership updated. Congrats @kennytm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants