Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "vote: gozssky as TiKV reviwer" #142

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Sep 6, 2021

Reverts #141

violate governance rule

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BusyJay

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

This reverts commit d8759de.

Signed-off-by: tison <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2021
@JaySon-Huang
Copy link

(not important) I think it should be "violate" instead of "violet"?👀

@tisonkun
Copy link
Contributor Author

tisonkun commented Sep 6, 2021

@JaySon-Huang yes. Updated.

@skyzh
Copy link
Member

skyzh commented Sep 6, 2021

This seems to be the first time that our rules are violated. After this accident has happened, I believe for now all of the community members should have been acknowledged the promotion rules.

So as for this PR, to simplify the process, I suggest that we simply wait for 3 days. If there are no vetoes and this promotion meets the requirements, we may close this PR and assume #141 valid.

After all, thanks for @gozssky 's contribution!

+1 (binding)

@tisonkun
Copy link
Contributor Author

tisonkun commented Sep 6, 2021

@skyzh thanks for your suggestion. I highly respect @gozssky's contribution, but hesitated to make a special case that

close this PR and assume #141 valid.

or something. If we allow this time, what about the next time we continue "assume an invalid vote passed". We should create as less exceptions as possible.

It's fine to the nominator proposes once more. We don't have to rush things or chasing just in place convenience, but keep the rules we wrote down.

@skyzh
Copy link
Member

skyzh commented Sep 6, 2021

Looks good to me. We could go over the process again.

@skyzh skyzh merged commit 09b9cba into master Sep 6, 2021
@tisonkun tisonkun deleted the revert-141-reviwer-1 branch September 6, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants