-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "vote: gozssky as TiKV reviwer" #142
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
This reverts commit d8759de. Signed-off-by: tison <[email protected]>
bf0e9dc
to
a70607e
Compare
(not important) I think it should be "violate" instead of "violet"?👀 |
@JaySon-Huang yes. Updated. |
This seems to be the first time that our rules are violated. After this accident has happened, I believe for now all of the community members should have been acknowledged the promotion rules. So as for this PR, to simplify the process, I suggest that we simply wait for 3 days. If there are no vetoes and this promotion meets the requirements, we may close this PR and assume #141 valid. After all, thanks for @gozssky 's contribution! +1 (binding) |
@skyzh thanks for your suggestion. I highly respect @gozssky's contribution, but hesitated to make a special case that
or something. If we allow this time, what about the next time we continue "assume an invalid vote passed". We should create as less exceptions as possible. It's fine to the nominator proposes once more. We don't have to rush things or chasing just in place convenience, but keep the rules we wrote down. |
Looks good to me. We could go over the process again. |
Reverts #141
violate governance rule