Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update team.json in alphabetical order #152

Merged
merged 1 commit into from
Oct 3, 2021
Merged

docs: update team.json in alphabetical order #152

merged 1 commit into from
Oct 3, 2021

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Oct 3, 2021

Members in alphabetical order for easily reading. Mentioned at the beginning of the file.

@andylokandy PTAL.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 3, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • skyzh

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@tisonkun
Update team.json
e591a7b 
Signed-off-by: tison <[email protected]>
skyzh
skyzh approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will there be CI scripts to check this?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 3, 2021
@tisonkun
Copy link
Contributor Author

tisonkun commented Oct 3, 2021 •
edited
Loading

@skyzh Yes we can write a script and add a GitHub Actions checking this JSON file with customized rule.

Could you please create an issue for that? And also mark it as help wanted. I MAY work on it where there is spare time.

@tisonkun
Copy link
Contributor Author

tisonkun commented Oct 3, 2021

/merge

Not a vote.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e591a7b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 3, 2021
@ti-chi-bot ti-chi-bot merged commit 1bda289 into master Oct 3, 2021
@skyzh skyzh deleted the tisonkun-patch-1 branch October 3, 2021 15:38
@skyzh skyzh mentioned this pull request Oct 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tisonkun @ti-chi-bot @skyzh