set --disable-stats if stats feature is not enabled (#82)

jemalloc defaults to enabling stats if `--enable-stats` is not present and `--disable-stats` was not set: https://github.com/jemalloc/jemalloc/blob/fa451de17fff73cc03c31ec8cd817d62927d1ff9/configure.ac#L1331-L1333 the stats feature was always enabled by default and never respected if someone were to remove the stats feature as no logic was added for setting `--disable-stats`. to avoid breaking other user's setups who are relying on this behaviour, set stats as a default feature. Signed-off-by: strawberry <[email protected]>
tikv · May 10, 2024 · 86e9248 · 86e9248
1 parent 805804a
commit 86e9248
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/jemalloc-sys/Cargo.toml b/jemalloc-sys/Cargo.toml
@@ -32,7 +32,7 @@ libc = { version = "^0.2.8", default-features = false }
 cc = "^1.0.13"
 
 [features]
-default = ["background_threads_runtime_support"]
+default = ["stats", "background_threads_runtime_support"]
 profiling = []
 debug = []
 background_threads_runtime_support = []

diff --git a/jemalloc-sys/build.rs b/jemalloc-sys/build.rs
@@ -265,6 +265,9 @@ fn main() {
     if env::var("CARGO_FEATURE_STATS").is_ok() {
         info!("CARGO_FEATURE_STATS set");
         cmd.arg("--enable-stats");
+    } else {
+        info!("CARGO_FEATURE_STATS not set");
+        cmd.arg("--disable-stats");
     }
 
     if env::var("CARGO_FEATURE_DISABLE_INITIAL_EXEC_TLS").is_ok() {

diff --git a/jemallocator/Cargo.toml b/jemallocator/Cargo.toml
@@ -41,7 +41,7 @@ paste = "1"
 tikv-jemalloc-ctl = { path = "../jemalloc-ctl", version = "0.5.0" }
 
 [features]
-default = ["background_threads_runtime_support"]
+default = ["stats", "background_threads_runtime_support"]
 alloc_trait = []
 profiling = ["tikv-jemalloc-sys/profiling"]
 debug = ["tikv-jemalloc-sys/debug"]