build: Fix build on riscv64gc-unknown-linux-musl #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BusyJay
approved these changes
Oct 18, 2023
|
DCO needs to be fixed. |
marv
force-pushed
the
fix-configure-for-riscv64gc-unknown-linux-musl
branch
from
f5b7046
to
864f8e8
Compare
|
Gentle ping |
|
Can you rebase the latest main branch? |
The configure step for jemalloc fails to recognize the rustc target `riscv64gc-unknown-linux-musl`: ``` --- stderr Invalid configuration `riscv64gc-unknown-linux-musl': machine `riscv64gc-unknown' not recognized configure: error: /bin/sh build-aux/config.sub riscv64gc-unknown-linux-musl failed thread 'main' panicked at /home/marv/.cargo/registry/src/index.crates.io-6f17d22bba15001f/jemalloc-sys-0.5.4+5.3.0-patched/build.rs:351:9: command did not execute successfully: cd "/mnt/data/devel/ripgrep/target/release/build/jemalloc-sys-eb3f9d51d93e319f/out/build" && CC="cc" CFLAGS="-O3 -ffunction-sections -fdata-sections -fPIC -gdwarf-4 -fno-omit-frame-pointer -march=rv64gc -mabi=lp64d -mcmodel=medany -Wall -g -ggdb3 -O0" CPPFLAGS="-O3 -ffunction-sections -fdata-sections -fPIC -gdwarf-4 -fno-omit-frame-pointer -march=rv64gc -mabi=lp64d -mcmodel=medany -Wall -g -ggdb3 -O0" LDFLAGS="-O3 -ffunction-sections -fdata-sections -fPIC -gdwarf-4 -fno-omit-frame-pointer -march=rv64gc -mabi=lp64d -mcmodel=medany -Wall -g -ggdb3 -O0" "sh" "/mnt/data/devel/ripgrep/target/release/build/jemalloc-sys-eb3f9d51d93e319f/out/build/configure" "--disable-cxx" "--enable-doc=no" "--enable-shared=no" "--with-jemalloc-prefix=_rjem_" "--with-private-namespace=_rjem_" "--host=riscv64gc-unknown-linux-musl" "--build=riscv64gc-unknown-linux-musl" "--prefix=/mnt/data/devel/ripgrep/target/release/build/jemalloc-sys-eb3f9d51d93e319f/out" expected success, got: exit status: 1 ``` Add an entry to build.rs to translate between the GNU target and rustc target in order to work around the mismatch Signed-off-by: Marvin Schmidt <[email protected]>
marv
force-pushed
the
fix-configure-for-riscv64gc-unknown-linux-musl
branch
from
864f8e8
to
ae87e7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configure step for jemalloc fails to recognize the rustc target
riscv64gc-unknown-linux-musl:Add an entry to build.rs to translate between the GNU target and rustc target in order to work around the mismatch