Allow unprefixed jemalloc on musl targets #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to sign off your commit first. |
Signed-off-by: Jack Kleeman <[email protected]>
jackkleeman
force-pushed
the
musl-targets
branch
from
2277a22
to
ec5b587
Compare
|
@BusyJay thanks, fixed |
girlbossceo
added a commit
to girlbossceo/jemallocator
that referenced
this pull request
Aug 18, 2024
This reverts commit f7adfca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Musl has supported replaced allocators since 1.1.20, about a year after this exclusion was added. I have tested and I find no problems with jemalloc musl binaries. It seems reasonable to hand the responsibility for checking that their musl supports this back to the end user who is enabling the flag