allow per-target env detection #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torrekie
force-pushed
the
patch-per-target-env
branch
from
b316bf7
to
c2234c2
Compare
BusyJay
reviewed
Jun 17, 2024
Signed-off-by: Torrekie <[email protected]>
Signed-off-by: Torrekie <[email protected]>
Torrekie
force-pushed
the
patch-per-target-env
branch
from
c2234c2
to
88b54a4
Compare
BusyJay
reviewed
Jun 17, 2024
Signed-off-by: Torrekie <[email protected]>
|
You can ignore the aarch64 failure. The clippy failure is not related to your change, but if you can fix it in this PR we can merge it all together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #90.
It allows all environment variables that detected by
read_and_watch_envandread_and_watch_env_osto be general or target-specific, which allows some unavoidable cross-compiling scene.When compiling jemalloc-sys under Cargo projects,
TARGETis set. Variables can be set as target-specific in the form of<TARGET_TRIPLE>_MYENV. For example,AARCH64_APPLE_IOS_JEMALLOC_OVERRIDEwill setJEMALLOC_OVERRIDEwhen cargo is targeting aarch64-apple-ios, which is not affecting other targets.When
AARCH64_APPLE_IOS_JEMALLOC_OVERRIDEandJEMALLOC_OVERRIDEare both set, the build.rs will prefer prefixed one instead of the non-prefixed one. The unprefixed one would only be used when target-specific one is not set.