[close #287] fix alertmanager for tikv-cdc #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zeminzhou <[email protected]>
pingyu
reviewed
Nov 3, 2022
| @@ -2,111 +2,99 @@ groups: | |||
| - name: alert.rules | |||
| rules: | |||
| - alert: cdc_multiple_owners | |||
| expr: sum(rate(ticdc_owner_ownership_counter[30s])) >= 2 | |||
There was a problem hiding this comment.
Suggest:
- Rename the file to
tikv-cdc.rules.yml. - Change the alert names to avoid conflict with TiCDC.
- Change "cdc" to "TiKV-CDC" in
summaryto avoid misunstanding of user.
There was a problem hiding this comment.
Good suggest, modified, thanks!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
================================================
+ Coverage 54.4448% 54.6869% +0.2421%
================================================
Files 238 238
Lines 20237 20237
================================================
+ Hits 11018 11067 +49
+ Misses 8341 8273 -68
- Partials 878 897 +19
*This pull request uses carry forward flags. Click here to find out more.
|
Signed-off-by: zeminzhou <[email protected]>
Signed-off-by: zeminzhou <[email protected]>
|
/verify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zeminzhou [email protected]
What problem does this PR solve?
Issue Number: close #287
Problem Description: TBD
What is changed and how does it work?
ticdc -> tikv-cdc
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes