-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix #67] fix golangci-lint failures for TiKV BR #70
Conversation
Signed-off-by: Jian Zhang <[email protected]>
/verify |
a028213
to
1766eb8
Compare
Signed-off-by: Jian Zhang <[email protected]>
1766eb8
to
4bd72cb
Compare
Signed-off-by: Jian Zhang <[email protected]>
|
Signed-off-by: Jian Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jian Zhang [email protected]
What problem does this PR solve?
Issue Number: [fix #67]
Problem Description: golangci-lint failure is the last breaking check in CI
What is changed and how does it work?
there are lots of lint failures, I fixed them in two ways:
goimports -e -w .
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes