Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix #67] fix golangci-lint failures for TiKV BR #70

Merged
merged 4 commits into from
Mar 22, 2022

Conversation

zz-jason
Copy link
Member

Signed-off-by: Jian Zhang [email protected]

What problem does this PR solve?

Issue Number: [fix #67]

Problem Description: golangci-lint failure is the last breaking check in CI

What is changed and how does it work?

there are lots of lint failures, I fixed them in two ways:

  • goimports failures are fixed by goimports -e -w .
  • others are fixed manually

Code changes

  • Has exported function/method change

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test

Side effects

  • No side effects

Related changes

  • No related changes

@zz-jason
Copy link
Member Author

/verify

@zz-jason zz-jason force-pushed the fix/fix-br-golangci branch 2 times, most recently from a028213 to 1766eb8 Compare March 21, 2022 15:58
@zz-jason
Copy link
Member Author

golangci-lint faild in verify is caused by:

[](https://ci.pingcap.net/blue/organizations/jenkins/lint-check/detail/lint-check/3563/pipeline/#step-55-log-156)[](https://ci.pingcap.net/blue/organizations/jenkins/lint-check/detail/lint-check/3563/pipeline/#step-55-log-157)[2022-03-22T02:04:32.574Z] level=info msg="[loader] Go packages loading at mode 575 (name|compiled_files|exports_file|files|imports|deps|types_sizes) took 1m0.947348183s"
[2022-03-22T02:04:32.574Z] level=error msg="Running error: context loading failed: failed to load packages: timed out to load packages: context deadline exceeded"
[2022-03-22T02:04:32.574Z] level=error msg="Timeout exceeded: try increasing it by passing --timeout option"

--timeout parameter of golangci-lint is default to 1m, I changed it to 10m in the CI / br-golangci-lint workflow.

Signed-off-by: Jian Zhang <[email protected]>
Copy link
Contributor

@zeminzhou zeminzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Collaborator

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pingyu pingyu merged commit 2b13212 into tikv:main Mar 22, 2022
@zz-jason zz-jason deleted the fix/fix-br-golangci branch March 22, 2022 04:07
This was referenced Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiKV BR Development Tasks
3 participants