[to #67] remove unused code related to parser #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jian Zhang <[email protected]>
|
now only the following places directly relaies on parser, I'll try to remove them later in this PR: |
Signed-off-by: Jian Zhang <[email protected]>
Signed-off-by: Jian Zhang <[email protected]>
Signed-off-by: Jian Zhang <[email protected]>
zz-jason
force-pushed
the
fix/remove-parser-related-files
branch
from
cdb65b5
to
1aef0c7
Compare
pingyu
reviewed
Mar 30, 2022
| ) | ||
|
|
||
| // LoadRestoreStores loads the stores used to restore data. | ||
| func (rc *Client) LoadRestoreStores(ctx context.Context) error { |
There was a problem hiding this comment.
These methods seems to be used to stop PD scheduling regions during restore, as we have pre-splitted regions. But need some changes (on the table codes).
There was a problem hiding this comment.
Yes. We can add it back once needed.
zeminzhou
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jian Zhang [email protected]
What problem does this PR solve?
Issue Number: [to #67]
Problem Description: I found br relies on pingcap/parser, which makes the dependency hard to manage, i.e, upgrade some packages like kvproto to a newer version
What is changed and how does it work?
this pr aims to delete parser related functions and simplify the dependency
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes