[to #67] setup backup/restore integration test for rawkv #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jian Zhang <[email protected]>
zz-jason
force-pushed
the
feature/setup-integration-test
branch
4 times, most recently
from
566bb96
to
1b7031b
Compare
Signed-off-by: Jian Zhang <[email protected]>
zz-jason
force-pushed
the
feature/setup-integration-test
branch
from
1b7031b
to
683eee3
Compare
|
@pingyu @zeminzhou this pr is ready for review, PTAL. Thanks! |
pingyu
approved these changes
Apr 6, 2022
| # start tikv in apiv1ttl | ||
| /home/runner/.tiup/bin/tiup playground ${{ matrix.tikv_version }} --mode tikv-slim --kv 1 --without-monitor --kv.config /home/runner/work/migration/migration/.github/config/br_rawkv.toml --pd.config /home/runner/work/migration/migration/.github/config/br_pd.toml &> raw.out 2>&1 & | ||
| # The first run of `tiup` has to download all components so it'll take longer. | ||
| sleep 1m 30s |
There was a problem hiding this comment.
Maybe later we can find a way to detect whether tiup is done, to make CI more stable. As well as a better way to get the PD port, independent to the output message.
zeminzhou
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jian Zhang [email protected]
What problem does this PR solve?
Issue Number: [to #67]
Problem Description:
What is changed and how does it work?
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes