Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: defensive reads for all thread locals #161

Merged
merged 5 commits into from
Aug 20, 2023

Conversation

zhongzc
Copy link
Collaborator

@zhongzc zhongzc commented Aug 20, 2023

fix #160

@coveralls
Copy link

coveralls commented Aug 20, 2023

Pull Request Test Coverage Report for Build 5916385128

  • 27 of 37 (72.97%) changed or added relevant lines in 9 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 82.849%

Changes Missing Coverage Covered Lines Changed/Added Lines %
minitrace/src/collector/id.rs 7 8 87.5%
minitrace/src/local/local_collector.rs 2 3 66.67%
minitrace/src/local/local_span.rs 2 3 66.67%
minitrace/src/local/span_queue.rs 1 2 50.0%
minitrace/src/event.rs 0 2 0.0%
minitrace/src/span.rs 5 7 71.43%
minitrace/src/util/mod.rs 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
minitrace/src/local/local_collector.rs 1 94.32%
minitrace/src/local/local_span.rs 1 92.19%
minitrace/src/span.rs 1 97.44%
Totals Coverage Status
Change from base Build 5689564312: -0.3%
Covered Lines: 1652
Relevant Lines: 1994

💛 - Coveralls

Signed-off-by: Zhenchi <[email protected]>
@drmingdrmer
Copy link

Thank you for this quick fix! We'll proceed to examine it out in our environment as soon as it merged!

minitrace/src/collector/global_collector.rs Outdated Show resolved Hide resolved
minitrace/src/collector/mod.rs Outdated Show resolved Hide resolved
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
@zhongzc zhongzc merged commit 7713549 into tikv:master Aug 20, 2023
8 checks passed
@zhongzc zhongzc deleted the zhongzc/tls-all-try-with branch August 20, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic with AccessError when logging in a drop
4 participants