address the comment

Signed-off-by: Ryan Leung <[email protected]>
tikv · Feb 2, 2023 · fd56a3d · fd56a3d
1 parent 974bccd
commit fd56a3d
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/pkg/mock/mockcluster/mockcluster.go b/pkg/mock/mockcluster/mockcluster.go
@@ -227,7 +227,7 @@ func (mc *Cluster) SetStoreDown(storeID uint64) {
 	store := mc.GetStore(storeID)
 	newStore := store.Clone(
 		core.UpStore(),
-		core.SetLastHeartbeatTS(time.Time{}),
+		core.SetLastHeartbeatTS(typeutil.ZeroTime),
 	)
 	mc.PutStore(newStore)
 }

diff --git a/pkg/storage/endpoint/key_path.go b/pkg/storage/endpoint/key_path.go
@@ -44,7 +44,7 @@ const (
 	regionPathPrefix           = "raft/r"
 	// resource group storage endpoint has prefix `resource_group`
 	resourceGroupSettingsPath = "settings"
-
+	// tso storage endpoint has prefix `tso`
 	microserviceKey = "microservice"
 	tsoServiceKey   = "tso"
 	timestampKey    = "timestamp"

diff --git a/pkg/storage/endpoint/tso.go b/pkg/storage/endpoint/tso.go
@@ -46,10 +46,10 @@ func (se *StorageEndpoint) LoadTimestamp(keyspaceGroupName string, dcLocationKey
 	prefixEnd := clientv3.GetPrefixRangeEnd(prefix)
 	keys, values, err := se.LoadRange(prefix, prefixEnd, 0)
 	if err != nil {
-		return time.Time{}, err
+		return typeutil.ZeroTime, err
 	}
 	if len(keys) == 0 {
-		return time.Time{}, nil
+		return typeutil.ZeroTime, nil
 	}
 
 	maxTSWindow := typeutil.ZeroTime

diff --git a/server/cluster/coordinator_test.go b/server/cluster/coordinator_test.go
@@ -124,7 +124,7 @@ func (c *testCluster) setStoreDown(storeID uint64) error {
 	store := c.GetStore(storeID)
 	newStore := store.Clone(
 		core.UpStore(),
-		core.SetLastHeartbeatTS(time.Time{}),
+		core.SetLastHeartbeatTS(typeutil.ZeroTime),
 	)
 	c.Lock()
 	defer c.Unlock()