Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After changing flow-round-by-digit, the region statistics are not updated #4295

Closed
HunDunDM opened this issue Nov 5, 2021 · 0 comments · Fixed by #4304
Closed

After changing flow-round-by-digit, the region statistics are not updated #4295

HunDunDM opened this issue Nov 5, 2021 · 0 comments · Fixed by #4304
Assignees
@HunDunDM
Labels
type/bug The issue is confirmed as a bug.

Comments

@HunDunDM
Copy link
Member

HunDunDM commented Nov 5, 2021

Bug Report

What did you do?

  • start a TiDB cluster
  • run some tasks
  • set PD config flow-round-by-digit = 127
  • stop all tasks and wait for a while
  • set PD config flow-round-by-digit = 3
  • observe the Key Visualizer in TiDB Dashboard

What did you expect to see?

After stopping the task, Key Visualizer should show no flow.

What did you see instead?

image

What version of PD are you using (pd-server -V)?

v5.2.2
@HunDunDM HunDunDM added the type/bug The issue is confirmed as a bug. label Nov 5, 2021
@HunDunDM HunDunDM self-assigned this Nov 5, 2021
HunDunDM added a commit to HunDunDM/pd that referenced this issue Nov 8, 2021
@HunDunDM
cluster: fix the bug that region statistics are not updated after flo…
4e2dc59 
…w-round-by-digit change

close tikv#4295

Signed-off-by: HunDunDM <[email protected]>
@HunDunDM HunDunDM mentioned this issue Nov 8, 2021
Merged
ti-chi-bot pushed a commit that referenced this issue Nov 8, 2021
@HunDunDM
cluster: fix the bug that region statistics are not updated after flo…
7aebe05 
…w-round-by-digit change (#4304)

* cluster: fix the bug that region statistics are not updated after flow-round-by-digit change

close #4295

Signed-off-by: HunDunDM <[email protected]>

* refine some code

Signed-off-by: HunDunDM <[email protected]>

* address comment

Signed-off-by: HunDunDM <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 8, 2021
@HunDunDM @ti-chi-bot
cluster: fix the bug that region statistics are not updated after flo…
d446b41 
…w-round-by-digit change

close tikv#4295

Signed-off-by: HunDunDM <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 8, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 8, 2021
@HunDunDM @ti-chi-bot
cluster: fix the bug that region statistics are not updated after flo…
5f95924 
…w-round-by-digit change

close tikv#4295

Signed-off-by: HunDunDM <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 8, 2021
Merged
ti-chi-bot added a commit that referenced this issue Nov 8, 2021
@ti-chi-bot @HunDunDM
cluster: fix the bug that region statistics are not updated after flo…
e8e8c1f 
…w-round-by-digit change (#4304) (#4305)

* cluster: fix the bug that region statistics are not updated after flow-round-by-digit change

close #4295

Signed-off-by: HunDunDM <[email protected]>

* refine some code

Signed-off-by: HunDunDM <[email protected]>

* address comment

Signed-off-by: HunDunDM <[email protected]>

Co-authored-by: HunDunDM <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Nov 12, 2021
@HunDunDM @ti-chi-bot
cluster: fix the bug that region statistics are not updated after flo…
9a73415 
…w-round-by-digit change

close tikv#4295

Signed-off-by: HunDunDM <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Nov 12, 2021
Merged
hzh0425 pushed a commit to hzh0425/pd that referenced this issue Nov 16, 2021
@HunDunDM @hzh0425
cluster: fix the bug that region statistics are not updated after flo…
3325059 
…w-round-by-digit change (tikv#4304)

* cluster: fix the bug that region statistics are not updated after flow-round-by-digit change

close tikv#4295

Signed-off-by: HunDunDM <[email protected]>

* refine some code

Signed-off-by: HunDunDM <[email protected]>

* address comment

Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: hzh0425 <[email protected]>
ti-chi-bot added a commit that referenced this issue Nov 30, 2021
@ti-chi-bot @HunDunDM
cluster: fix the bug that region statistics are not updated after flo…
bcab636 
…w-round-by-digit change (#4304) (#4329)

* cluster: fix the bug that region statistics are not updated after flow-round-by-digit change

close #4295

Signed-off-by: HunDunDM <[email protected]>

* refine some code

Signed-off-by: HunDunDM <[email protected]>

* address comment

Signed-off-by: HunDunDM <[email protected]>

Co-authored-by: HunDunDM <[email protected]>
ti-chi-bot added a commit that referenced this issue Nov 30, 2021
@ti-chi-bot @HunDunDM
cluster: fix the bug that region statistics are not updated after flo…
6717f3f 
…w-round-by-digit change (#4304) (#4306)

* cluster: fix the bug that region statistics are not updated after flow-round-by-digit change

close #4295

Signed-off-by: HunDunDM <[email protected]>

* refine some code

Signed-off-by: HunDunDM <[email protected]>

* address comment

Signed-off-by: HunDunDM <[email protected]>

Co-authored-by: HunDunDM <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HunDunDM HunDunDM

Labels
type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
1 participant
@HunDunDM