Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misuse of trace region in tso_dispatcher #8534

Open
zyguan opened this issue Aug 15, 2024 · 1 comment
Open

Misuse of trace region in tso_dispatcher #8534

zyguan opened this issue Aug 15, 2024 · 1 comment
Labels
may-affects-5.4 may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 severity/major type/bug The issue is confirmed as a bug.

Comments

@zyguan
Copy link

zyguan commented Aug 15, 2024

pd/client/tso_dispatcher.go

Lines 413 to 415 in 1b8fc6a

for i := range traceRegions {
traceRegions[i].End()
}

Here Region.End should be called in reversed order, otherwise, it makes trace out broken.

2024-08-15_154136
@ti-chi-bot ti-chi-bot bot added the needs-type Indicates an issue requires a type label. label Aug 15, 2024
@zyguan
Copy link
Author

zyguan commented Aug 15, 2024

/type bug

@ti-chi-bot ti-chi-bot bot added type/bug The issue is confirmed as a bug. and removed needs-type Indicates an issue requires a type label. labels Aug 15, 2024
zyguan added a commit to zyguan/pd that referenced this issue Sep 4, 2024
@zyguan
fix tikv#8534
77b4024 
Signed-off-by: zyguan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
may-affects-5.4 may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 severity/major type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Need Triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jebter @zyguan