ReAdd peer meta. #101
Merged
ReAdd peer meta. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for _, peerStoreID := range region.StoreIds { | ||
| if peerStoreID == storeID { | ||
| for _, peer := range region.Peers { | ||
| if peer.GetStoreId() == storeID { | ||
| // we can't add peer in the same store. |
There was a problem hiding this comment.
tip: maybe we'll allow this later, but allocate a new peer id and recycle the old peer.
There was a problem hiding this comment.
why should support this?
A store can only have one peer for the region. Pd must remove first, then add again.
|
LGTM |
1 similar comment
|
LGTM |
rleungx
pushed a commit
to rleungx/pd
that referenced
this pull request
Jun 5, 2023
* Fix tso server close stuck issue (tikv#6529) ref tikv#5895, close tikv#6304 Rewrite TSO gPRC/HTTP server Close(). Signed-off-by: Bin Shi <[email protected]> * mcs, tso: change keyspace group primary path. (tikv#6526) ref tikv#5895 mcs, tso: change keyspace group primary path. The path for non-default keyspace group primary election changes from "/ms/{cluster_id}/tso/{group}/primary" to "/ms/{cluster_id}/tso/keyspace_groups/election/{group}/primary". Default keyspace group keeps /ms/{cluster_id}/tso/00000/primary. Signed-off-by: Bin Shi <[email protected]> --------- Signed-off-by: Bin Shi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.