pdctl: fix region key problems in detach mode #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disksing
reviewed
Oct 26, 2018
| @@ -303,8 +324,7 @@ func showRegionsFromStartKeyCommandFunc(cmd *cobra.Command, args []string) { | |||
| fmt.Println("Error: unknown format") | |||
| return | |||
| } | |||
| // TODO: Deal with path escaped | |||
| prefix := regionKeyPrefix + "/" + key | |||
| prefix := regionKeyPrefix + "/" + url.QueryEscape(key) | |||
There was a problem hiding this comment.
Do we need to update server-side to adapt this change?
There was a problem hiding this comment.
It seems #1299 will deal with this problem. I will remove it from this PR.
|
/rebuild |
disksing
approved these changes
Oct 26, 2018
disksing
added
the
needs-cherry-pick-release-2.1
disksing
pushed a commit
to oh-my-tidb/pd
that referenced
this pull request
Nov 8, 2018
disksing
added a commit
that referenced
this pull request
Nov 8, 2018
* pdctl: fix region key problems in detach mode (#1298) * pd-ctl: escape the key before query the corresponding region (#1299) * pdctl: fix decode key (#1308) Signed-off-by: disksing <[email protected]>
nolouch
added
the
needs-cherry-pick-release-2.0
disksing
added a commit
to oh-my-tidb/pd
that referenced
this pull request
Nov 14, 2018
disksing
added a commit
that referenced
this pull request
Nov 14, 2018
* server, client: fix hanging problem when etcd failed to start (#1267) * server: use same initialcluster config to restart joined member (#1279) * fix server build * pdctl: cherry pick bugfixes (#1298, #1299, #1308) * server/api: fix the issue about `regions/check` API (#1311) * fix join build * fix pdctl build * fix region test * fix warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently,
pd-ctldoesn't support using--formatin detach mode and also can not decode the key which contains some escape characters, such as\n.What is changed and how it works?
This PR fixes this two problems. After this PR, we need to wrap the key with single quotes
'inpd-ctl.For example, we can use the below command to find the region for a given key:
Check List
Tests
Related changes