*: tiny refactor config. #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fs.Uint64Var(&cfg.AdvertiseClientPort, "advertise-client-port", 0, "advertise port for client traffic (default '{client-port}')") | ||
| fs.Uint64Var(&cfg.PeerPort, "peer-port", defaultPeerPort, "port for peer traffic") | ||
| fs.Uint64Var(&cfg.AdvertisePeerPort, "advertise-peer-port", 0, "advertise port for peer traffic (default '{peer-port}')") | ||
| fs.StringVar(&cfg.InitialCluster, "initial-cluser", defaultInitialCluster, "initial cluster configuration for bootstrapping (default '{name}=http://{host}:{advertise-peer-port}')") |
There was a problem hiding this comment.
I think we can remove defaultInitialCluster and leave empty here.
So if user doesn't set it, default used, but here default may be not defaultInitialCluster.
|
LGTM |
|
@huachaohuang PTAL |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #210
Reduce some flags and refactor config parser.
/cc @siddontang @huachaohuang @overvenus