Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

member, server: remove some invalid function parameters #2883

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Sep 3, 2020

Signed-off-by: JmPotato [email protected]

What problem does this PR solve?

Part of #2759. Remove invalid parameters for the function member.CheckLeader().

What is changed and how it works?

Remove unused function parameters.

Check List

Tests

  • Unit test

Release note

  • Remove some invalid function parameters.

@JmPotato JmPotato added the component/election Election related logic. label Sep 3, 2020
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 3, 2020
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 3, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 3, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 3, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@JmPotato merge failed.

@JmPotato
Copy link
Member Author

JmPotato commented Sep 3, 2020

/run-integration-lightning-test

@JmPotato JmPotato merged commit 6181a4a into tikv:master Sep 3, 2020
@JmPotato JmPotato deleted the remove_invalid_parameters branch September 3, 2020 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/election Election related logic. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants