server: Refine log error format (#2873) #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
ti-srebot
added
contribution
|
@ZenoTan please accept the invitation then you can push to the cherry-pick pull requests. |
ZenoTan
force-pushed
the
release-4.0-12a08b130644
branch
from
79ba4b9
to
4a20d66
Compare
Signed-off-by: ZenoTan <[email protected]>
Signed-off-by: ZenoTan <[email protected]>
Signed-off-by: ZenoTan <[email protected]>
…ot/pd into release Signed-off-by: ZenoTan <[email protected]>
ZenoTan
force-pushed
the
release-4.0-12a08b130644
branch
2 times, most recently
from
c6897b7
to
2efe415
Compare
Signed-off-by: ZenoTan <[email protected]>
rleungx
reviewed
Sep 7, 2020
server/id/id.go
Outdated
| @@ -14,10 +14,10 @@ | |||
| package id | |||
|
|
|||
| import ( | |||
| "github.com/tikv/pd/pkg/errs" | |||
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2911 +/- ##
===============================================
+ Coverage 77.16% 77.24% +0.08%
===============================================
Files 204 210 +6
Lines 21940 22857 +917
===============================================
+ Hits 16931 17657 +726
- Misses 3724 3853 +129
- Partials 1285 1347 +62
Continue to review full report at Codecov.
|
Signed-off-by: ZenoTan <[email protected]>
lhy1024
approved these changes
Sep 7, 2020
ti-srebot
added
status/LGT1
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
This was referenced Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2873 to release-4.0
Signed-off-by: ZenoTan [email protected]
What problem does this PR solve?
Refine log format in package server. Solve #2704
What is changed and how it works?
log.Erroranderrors.Errorfparts are changedCheck List
Tests
Code changes
Release note