test: add a new parameter to pass the server name for config #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JmPotato <[email protected]>
JmPotato
added
component/testing
Signed-off-by: JmPotato <[email protected]>
HunDunDM
reviewed
Sep 9, 2020
ti-srebot
approved these changes
Sep 9, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@JmPotato merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JmPotato [email protected]
What problem does this PR solve?
Before this PR, the
NewTestClusterin test can only create servers with the same config. But in some cases, we need to give different servers with different configs such asdc-locationfrom #2925. So I update theConfigOptionto make the config generator can pass the server name such aspd1with this function so that we can do some personalization to the configuration.What is changed and how it works?
Introduce a new parameter to pass the server name for config in
ConfigOption.Check List
Tests
Release note