Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tso: add the allocator checker #2992

Merged
merged 11 commits into from
Sep 24, 2020

Conversation

JmPotato
Copy link
Member

Signed-off-by: JmPotato [email protected]

What problem does this PR solve?

Part of #2984 and #2759. Prepare for the next step of implementing the global TSO generation algorithm.

What is changed and how it works?

After merging this pr, the AllocatorDaemon will check the dc-location config in the cluster periodically. If any new new dc-location found, it will set up the corresponding Local TSO Allocator.

Check List

Tests

  • Unit test

Release note

@JmPotato JmPotato added the component/tso Timestamp Oracle. label Sep 18, 2020
@JmPotato JmPotato self-assigned this Sep 18, 2020
@JmPotato
Copy link
Member Author

/rebuild

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

server/tso/allocator_manager.go Outdated Show resolved Hide resolved
server/tso/allocator_manager.go Outdated Show resolved Hide resolved
server/tso/allocator_manager.go Show resolved Hide resolved
@JmPotato
Copy link
Member Author

/run-all-tests

Signed-off-by: JmPotato <[email protected]>
@JmPotato
Copy link
Member Author

/run-all-tests

Signed-off-by: JmPotato <[email protected]>
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 23, 2020
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

server/tso/allocator_manager.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 24, 2020
@Yisaer
Copy link
Contributor

Yisaer commented Sep 24, 2020

/merge

@JmPotato
Copy link
Member Author

/run-all-tests

@ti-srebot
Copy link
Contributor

@Yisaer Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: scheduling(slack).

@JmPotato JmPotato merged commit 6e42fa5 into tikv:master Sep 24, 2020
@JmPotato JmPotato deleted the set_up_local_tso_allocator branch September 24, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tso Timestamp Oracle. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants