Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tso: reduce the frequency of interaction with etcd #3075

Merged
merged 8 commits into from
Oct 27, 2020

Conversation

JmPotato
Copy link
Member

Signed-off-by: JmPotato [email protected]

What problem does this PR solve?

Part of #2759 and close #3073. Reduce the overhead caused by the etcd interaction related to TSO.

What is changed and how it works?

  • Buffer the cluster DC location info to speed up the global TSO generation.
  • Reduce the frequency of interaction with etcd.
  • Make the TSO tests faster by reducing waiting time.

Check List

Tests

  • Unit test
  • Integration test

Release note

@JmPotato JmPotato added the component/tso Timestamp Oracle. label Oct 15, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2020
Signed-off-by: JmPotato <[email protected]>
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 27, 2020
@nolouch
Copy link
Contributor

nolouch commented Oct 27, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 3072
  • 3103

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@JmPotato merge failed.

@JmPotato
Copy link
Member Author

/run-all-tests

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yisaer
Copy link
Contributor

Yisaer commented Oct 27, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit b66fbb7 into tikv:master Oct 27, 2020
@JmPotato JmPotato deleted the reduce_etcd branch October 28, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tso Timestamp Oracle. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize GetClusterDCLocation to reduce CPU
7 participants