Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tso: refine the codes of TSO and TSO tests #3290

Merged
merged 5 commits into from
Dec 24, 2020

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Dec 21, 2020

Signed-off-by: JmPotato [email protected]

What problem does this PR solve?

Refine the codes of TSO and TSO tests.

What is changed and how it works?

  • Add and merge some common methods.
  • Refine the codes.
  • Add and adjust some comments.

Check List

Tests

  • Unit test
  • Integration test

Release note

@JmPotato JmPotato added the component/tso Timestamp Oracle. label Dec 21, 2020
@JmPotato JmPotato requested review from Yisaer and rleungx and removed request for disksing December 21, 2020 09:01
@JmPotato JmPotato marked this pull request as draft December 21, 2020 09:47
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2020
@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #3290 (935c59c) into master (38a764b) will increase coverage by 0.20%.
The diff coverage is 77.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3290      +/-   ##
==========================================
+ Coverage   74.62%   74.83%   +0.20%     
==========================================
  Files         243      243              
  Lines       23192    23207      +15     
==========================================
+ Hits        17308    17366      +58     
+ Misses       4308     4270      -38     
+ Partials     1576     1571       -5     
Flag Coverage Δ
unittests 74.83% <77.55%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/tso/global_allocator.go 64.56% <37.50%> (+1.86%) ⬆️
server/tso/allocator_manager.go 75.85% <93.33%> (-1.15%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <100.00%> (-0.59%) ⬇️
server/tso/tso.go 80.50% <100.00%> (+0.62%) ⬆️
pkg/dashboard/adapter/manager.go 81.52% <0.00%> (-7.61%) ⬇️
pkg/btree/btree.go 85.30% <0.00%> (-0.97%) ⬇️
client/client.go 65.67% <0.00%> (+0.37%) ⬆️
server/server.go 73.29% <0.00%> (+0.47%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a764b...935c59c. Read the comment docs.

@JmPotato JmPotato marked this pull request as ready for review December 21, 2020 12:58
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 21, 2020
@JmPotato
Copy link
Member Author

/run-build-image

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

server/tso/allocator_manager.go Show resolved Hide resolved
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 23, 2020
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 24, 2020
@nolouch
Copy link
Contributor

nolouch commented Dec 24, 2020

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 24, 2020
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 935c59c

@ti-chi-bot ti-chi-bot merged commit 08cb267 into tikv:master Dec 24, 2020
@JmPotato JmPotato deleted the refine_tso_codes branch December 24, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tso Timestamp Oracle. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants