Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region_syncer: reduce saveKV of client (#3808) #3993

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3808

What problem does this PR solve?

What is changed and how it works?

  • By introducing part of the heartbeat processing logic in the client of region_syncer, unnecessary saveKV operations are reduced.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

Improved the performance of synchronizing Region information between PDs.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved component/cluster Cluster logic. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick. labels Aug 16, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 16, 2021
@HunDunDM HunDunDM force-pushed the cherry-pick-3808-to-release-5.0 branch from 6e4a041 to d125637 Compare August 16, 2021 09:07
Signed-off-by: HunDunDM <[email protected]>
@HunDunDM
Copy link
Member

/rebuild

1 similar comment
@HunDunDM
Copy link
Member

/rebuild

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #3993 (d1d1ae8) into release-5.0 (88726b2) will decrease coverage by 0.22%.
The diff coverage is 92.68%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.0    #3993      +/-   ##
===============================================
- Coverage        74.89%   74.67%   -0.23%     
===============================================
  Files              245      245              
  Lines            24256    24276      +20     
===============================================
- Hits             18167    18128      -39     
- Misses            4485     4529      +44     
- Partials          1604     1619      +15     
Flag Coverage Δ
unittests 74.67% <92.68%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/region_syncer/client.go 81.69% <78.57%> (-1.02%) ⬇️
server/region_syncer/server.go 88.97% <83.33%> (+5.63%) ⬆️
server/core/region.go 90.61% <96.72%> (+0.86%) ⬆️
server/cluster/cluster.go 82.40% <100.00%> (-0.91%) ⬇️
server/schedulers/shuffle_hot_region.go 55.10% <0.00%> (-10.21%) ⬇️
server/election/leadership.go 83.52% <0.00%> (-5.89%) ⬇️
server/tso/tso.go 68.71% <0.00%> (-5.53%) ⬇️
server/election/lease.go 89.83% <0.00%> (-5.09%) ⬇️
server/member/member.go 66.84% <0.00%> (-4.35%) ⬇️
pkg/dashboard/adapter/manager.go 79.78% <0.00%> (-3.20%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88726b2...d1d1ae8. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2021
@nolouch
Copy link
Contributor

nolouch commented Aug 17, 2021

PTAL @rleungx

@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 27, 2021
@nolouch
Copy link
Contributor

nolouch commented Aug 27, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: acc28bf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 27, 2021
@ti-chi-bot ti-chi-bot merged commit f3c96e0 into tikv:release-5.0 Aug 27, 2021
@HunDunDM HunDunDM added this to the v5.0.4 milestone Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/cluster Cluster logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants