Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: speed scheduler exit (#4148) #4200

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4148

What problem does this PR solve?

closed #4146 speed schedule exit

What is changed and how it works?

pause scheduler after accept stop signal, and do not loop

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

speed scheduler exit  

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Oct 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick. labels Oct 12, 2021
Copy link
Contributor

@disksing disksing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need resolve conflict

Signed-off-by: bufferflies <[email protected]>
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #4200 (0a5d96f) into release-4.0 (ae08ed0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #4200      +/-   ##
===============================================
- Coverage        74.98%   74.97%   -0.01%     
===============================================
  Files              211      211              
  Lines            20061    20065       +4     
===============================================
+ Hits             15042    15043       +1     
- Misses            3693     3697       +4     
+ Partials          1326     1325       -1     
Flag Coverage Δ
unittests 74.97% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/cluster/cluster.go 77.77% <100.00%> (+0.88%) ⬆️
server/cluster/coordinator.go 68.43% <100.00%> (+0.33%) ⬆️
server/schedulers/shuffle_hot_region.go 57.14% <0.00%> (-12.50%) ⬇️
server/kv/etcd_kv.go 78.26% <0.00%> (-7.25%) ⬇️
server/heartbeat_streams.go 65.93% <0.00%> (-6.60%) ⬇️
pkg/etcdutil/etcdutil.go 72.05% <0.00%> (-5.89%) ⬇️
server/tso/tso.go 78.98% <0.00%> (-3.63%) ⬇️
pkg/mock/mockhbstream/mockhbstream.go 87.03% <0.00%> (-1.86%) ⬇️
server/grpc_service.go 59.87% <0.00%> (+0.40%) ⬆️
server/server.go 75.24% <0.00%> (+0.80%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae08ed0...0a5d96f. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 13, 2021
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 22, 2021
@VelocityLight
Copy link

/merge

@ti-chi-bot
Copy link
Member Author

@VelocityLight: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 96101b5

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. do-not-merge/invalid-commit-message labels Nov 22, 2021
@nolouch
Copy link
Contributor

nolouch commented Nov 24, 2021

ref #4146

@bufferflies bufferflies force-pushed the cherry-pick-4148-to-release-4.0 branch from 7021354 to cd2d333 Compare November 24, 2021 08:02
@ti-chi-bot ti-chi-bot removed do-not-merge/invalid-commit-message status/can-merge Indicates a PR has been approved by a committer. labels Nov 24, 2021
@VelocityLight
Copy link

/merge

@ti-chi-bot
Copy link
Member Author

@VelocityLight: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: cd2d333

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2021
@ti-chi-bot ti-chi-bot merged commit f11d191 into tikv:release-4.0 Nov 24, 2021
@zhouqiang-cl zhouqiang-cl added this to the v4.0.16 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants