Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: fix tso alert #4282

Merged
merged 3 commits into from
Nov 5, 2021
Merged

metrics: fix tso alert #4282

merged 3 commits into from
Nov 5, 2021

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Nov 4, 2021

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 added component/metrics Metrics. require-LGT1 Indicates that the PR requires an LGTM. labels Nov 4, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 4, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-commit-message release-note-none Denotes a PR that doesn't merit a release note. labels Nov 4, 2021
Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 added needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 labels Nov 4, 2021
@lhy1024 lhy1024 requested a review from JmPotato November 4, 2021 06:52
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #4282 (9cea65d) into master (e5d7be1) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4282      +/-   ##
==========================================
- Coverage   75.02%   74.98%   -0.05%     
==========================================
  Files         264      264              
  Lines       27255    27255              
==========================================
- Hits        20448    20436      -12     
- Misses       5001     5015      +14     
+ Partials     1806     1804       -2     
Flag Coverage Δ
unittests 74.98% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/region_syncer/server.go 83.08% <0.00%> (-5.89%) ⬇️
server/schedule/region_scatterer.go 80.70% <0.00%> (-4.39%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/tso/tso.go 63.63% <0.00%> (-2.85%) ⬇️
server/member/member.go 63.10% <0.00%> (-1.61%) ⬇️
server/core/storage.go 69.54% <0.00%> (-0.76%) ⬇️
server/schedule/operator_controller.go 83.50% <0.00%> (-0.41%) ⬇️
server/cluster/cluster.go 83.00% <0.00%> (-0.35%) ⬇️
client/client.go 71.99% <0.00%> (-0.24%) ⬇️
server/server.go 71.70% <0.00%> (+0.44%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d7be1...9cea65d. Read the comment docs.

Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 4, 2021
@nolouch
Copy link
Contributor

nolouch commented Nov 5, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9cea65d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2021
@ti-chi-bot
Copy link
Member

@lhy1024: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1d56091 into tikv:master Nov 5, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4288.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4289.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4290.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4291.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4292.

ti-chi-bot added a commit that referenced this pull request Nov 5, 2021
* fix

Signed-off-by: lhy1024 <[email protected]>

* close #4283

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: lhy1024 <[email protected]>
Co-authored-by: ShuNing <[email protected]>
hzh0425 pushed a commit to hzh0425/pd that referenced this pull request Nov 16, 2021
* fix

Signed-off-by: lhy1024 <[email protected]>

* close tikv#4283

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
Signed-off-by: hzh0425 <[email protected]>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Nov 16, 2021
* fix

Signed-off-by: lhy1024 <[email protected]>

* close tikv#4283

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
Signed-off-by: Cabinfever_B <[email protected]>
ti-chi-bot added a commit that referenced this pull request Nov 24, 2021
* fix

Signed-off-by: lhy1024 <[email protected]>

* close #4283

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: lhy1024 <[email protected]>
ti-chi-bot added a commit that referenced this pull request Nov 30, 2021
* fix

Signed-off-by: lhy1024 <[email protected]>

* close #4283

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: lhy1024 <[email protected]>
ti-chi-bot added a commit that referenced this pull request Nov 30, 2021
* fix

Signed-off-by: lhy1024 <[email protected]>

* close #4283

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: lhy1024 <[email protected]>
ti-chi-bot added a commit that referenced this pull request Nov 30, 2021
* fix

Signed-off-by: lhy1024 <[email protected]>

* close #4283

Signed-off-by: lhy1024 <[email protected]>

Co-authored-by: lhy1024 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics Metrics. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants