Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: reset stores cache before loading cluster info (#4942) #4959

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4942

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Close #4941.

What is changed and how does it work?

This PR resets the new leader store cache after transferring the PD leader.

Check List

Tests

  • Unit test

Release note

Fix the issue that the removed tombstone store shows again after transferring the PD leader

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added component/cluster Cluster logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. do-not-merge/cherry-pick-not-approved labels May 16, 2022
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx force-pushed the cherry-pick-4942-to-release-5.4 branch from 6862834 to 600afb6 Compare May 27, 2022 09:22
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Base: 74.73% // Head: 74.73% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d021ba2) compared to base (6555292).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-5.4    #4959      +/-   ##
===============================================
- Coverage        74.73%   74.73%   -0.01%     
===============================================
  Files              265      265              
  Lines            27998    28002       +4     
===============================================
+ Hits             20925    20926       +1     
- Misses            5209     5213       +4     
+ Partials          1864     1863       -1     
Flag Coverage Δ
unittests 74.73% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/cluster/cluster.go 82.74% <100.00%> (-0.10%) ⬇️
server/core/basic_cluster.go 91.62% <100.00%> (+0.14%) ⬆️
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
server/schedulers/shuffle_hot_region.go 55.55% <0.00%> (-10.11%) ⬇️
pkg/etcdutil/etcdutil.go 82.35% <0.00%> (-5.89%) ⬇️
server/schedule/region_scatterer.go 78.36% <0.00%> (-4.09%) ⬇️
server/election/leadership.go 75.25% <0.00%> (-2.07%) ⬇️
server/core/storage.go 69.31% <0.00%> (-1.52%) ⬇️
pkg/btree/btree.go 85.78% <0.00%> (-0.97%) ⬇️
client/client.go 72.51% <0.00%> (-0.22%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Jun 23, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 29, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 29, 2022
@nolouch
Copy link
Contributor

nolouch commented Aug 29, 2022

ptal @CabinfeverB

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 29, 2022
@nolouch
Copy link
Contributor

nolouch commented Sep 5, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 600afb6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 5, 2022
@ti-chi-bot ti-chi-bot merged commit d59e6ce into tikv:release-5.4 Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/cluster Cluster logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants