*: use independent lock

[rleungx]

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Ref #5586.

What is changed and how does it work?

This PR split the basic cluster lock into two and move out some logic from the lock section in the region heartbeat.

Check List

Tests

• Manual test

Test via 1000K Region/40 Store/1PD

8e18727

Update speed of each category:
  Requests/sec:     41370.8813
  Save-Tree/sec:     2482.2529
  Save-KV/sec:       1654.8353
  Save-Space/sec:    6205.6322
  Save-Flow/sec:    14479.8085
  Skip/sec:         20627.0333

7d128cb

Update speed of each category:
  Requests/sec:     34475.6364
  Save-Tree/sec:     2068.5382
  Save-KV/sec:       1379.0255
  Save-Space/sec:    5171.3455
  Save-Flow/sec:    12066.4727
  Skip/sec:         17189.1455

master:

Update speed of each category:
  Requests/sec:     25145.4940
  Save-Tree/sec:     1508.7296
  Save-KV/sec:       1005.8198
  Save-Space/sec:    3771.8241
  Save-Flow/sec:     8800.9229
  Skip/sec:         12537.2466

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• bufferflies
• nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Base: 75.73% // Head: 75.62% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (8badf14) compared to base (f4fa6f4).
Patch coverage: 90.50% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5587      +/-   ##
==========================================
- Coverage   75.73%   75.62%   -0.11%     
==========================================
  Files         326      326              
  Lines       32372    32386      +14     
==========================================
- Hits        24518    24493      -25     
- Misses       5757     5777      +20     
- Partials     2097     2116      +19     

Flag	Coverage Δ
unittests	75.62% <90.50%> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/cluster/cluster.go	82.95% <83.33%> (-0.19%)	⬇️
server/core/basic_cluster.go	90.18% <90.60%> (-1.88%)	⬇️
server/core/region.go	91.86% <100.00%> (+0.01%)	⬆️
server/core/region_tree.go	94.16% <100.00%> (ø)
pkg/errs/errs.go	75.00% <0.00%> (-25.00%)	⬇️
server/tso/local_allocator.go	64.86% <0.00%> (-13.52%)	⬇️
server/region_syncer/server.go	82.96% <0.00%> (-4.40%)	⬇️
server/storage/storage.go	67.30% <0.00%> (-3.85%)	⬇️
server/region_syncer/client.go	84.32% <0.00%> (-3.74%)	⬇️
pkg/etcdutil/etcdutil.go	84.88% <0.00%> (-3.49%)	⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[nolouch]

PTAL @CabinfeverB

[bufferflies]

rest LGTM

[nolouch]

lgtm

[nolouch]

/merge

[ti-chi-bot]

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 29c9e5b

[rleungx]

/run-cherry-picker

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5635.