-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schdeuler: Set resource with step for collecting plan #5591
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
server/schedule/plan/plan.go
Outdated
@@ -23,6 +23,7 @@ type Plan interface { | |||
|
|||
Clone(ops ...Option) Plan // generate plan for clone option | |||
SetResource(interface{}) | |||
SetResourceWithStep(interface{}, int) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about use enum?
@@ -83,3 +84,10 @@ func SetResource(resource interface{}) Option { | |||
plan.SetResource(resource) | |||
} | |||
} | |||
|
|||
// SetResource is used to generate Resource for plan | |||
func SetResourceWithStep(resource interface{}, step int) Option { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is it used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#5544 will need it
Codecov ReportBase: 75.72% // Head: 75.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5591 +/- ##
==========================================
+ Coverage 75.72% 75.80% +0.07%
==========================================
Files 326 326
Lines 32249 32253 +4
==========================================
+ Hits 24422 24449 +27
+ Misses 5716 5704 -12
+ Partials 2111 2100 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Cabinfever_B <[email protected]> address comment Signed-off-by: Cabinfever_B <[email protected]> address comment Signed-off-by: Cabinfever_B <[email protected]> address comment Signed-off-by: Cabinfever_B <[email protected]>
24b703d
to
a97faab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: a97faab
|
@CabinfeverB: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Cabinfever_B [email protected]
What problem does this PR solve?
Issue Number: ref #5539
If we determine which stores cannot be targets at the beginning of the scheduling, we should set resource with step.
What is changed and how does it work?
Check List
Tests
Release note