-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: Add check for unhealthy stores #5612
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Daniël van Eeden <[email protected]>
617240e
to
71b2c63
Compare
Codecov ReportBase: 75.76% // Head: 75.68% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5612 +/- ##
==========================================
- Coverage 75.76% 75.68% -0.09%
==========================================
Files 326 326
Lines 32386 32386
==========================================
- Hits 24538 24510 -28
- Misses 5746 5762 +16
- Partials 2102 2114 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 290fa54
|
@dveeden: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
When the filesystem of a TiKV node of a v5.3.0 cluster becomes read-only (e.g. due to filesystem errors, or simulated with
fsfreeze(8)
it seems tostore_disconneced_count
for 10m and then tostore_unhealth_count
for another 20m before eventually ending up instore_down_count
.Issue Number: Close #5611
See also pingcap/monitoring#172
What is changed and how does it work?
It looks like there isn't a check for
store_unhealth_count
, so that's what this PR tries to add.Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note