Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: improve region path #5636

Merged
merged 4 commits into from
Oct 27, 2022
Merged

*: improve region path #5636

merged 4 commits into from
Oct 27, 2022

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Oct 26, 2022

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Ref #5586.

What is changed and how does it work?

name           old time/op    new time/op    delta
RegionPath-40     601ns ±25%     213ns ± 5%  -64.51%  (p=0.008 n=5+5)

name           old alloc/op   new alloc/op   delta
RegionPath-40     96.0B ± 0%     48.0B ± 0%  -50.00%  (p=0.008 n=5+5)

name           old allocs/op  new allocs/op  delta
RegionPath-40      4.00 ± 0%      2.00 ± 0%  -50.00%  (p=0.008 n=5+5)

Before:
Screen Shot 2022-10-26 at 6 10 32 PM

After:
Screen Shot 2022-10-27 at 12 08 52 PM

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 26, 2022
Signed-off-by: Ryan Leung <[email protected]>
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 75.66% // Head: 75.72% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (b983009) compared to base (d033fbf).
Patch coverage: 81.25% of modified lines in pull request are covered.

❗ Current head b983009 differs from pull request most recent head 7072371. Consider uploading reports for the commit 7072371 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5636      +/-   ##
==========================================
+ Coverage   75.66%   75.72%   +0.06%     
==========================================
  Files         327      327              
  Lines       32420    32435      +15     
==========================================
+ Hits        24531    24562      +31     
+ Misses       5770     5757      -13     
+ Partials     2119     2116       -3     
Flag Coverage Δ
unittests 75.72% <81.25%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/storage/endpoint/key_path.go 92.85% <81.25%> (-7.15%) ⬇️
...erver/config/service_middleware_persist_options.go 91.66% <0.00%> (-8.34%) ⬇️
server/storage/kv/etcd_kv.go 79.71% <0.00%> (-5.80%) ⬇️
server/tso/tso.go 69.66% <0.00%> (-3.94%) ⬇️
server/member/member.go 64.21% <0.00%> (-3.16%) ⬇️
server/region_syncer/client.go 84.32% <0.00%> (-0.75%) ⬇️
server/server.go 74.43% <0.00%> (-0.64%) ⬇️
server/cluster/coordinator.go 72.48% <0.00%> (-0.59%) ⬇️
client/base_client.go 82.77% <0.00%> (-0.48%) ⬇️
client/client.go 68.91% <0.00%> (+0.10%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bufferflies
Copy link
Contributor

How about give some benchmark's comparison ?

Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx marked this pull request as ready for review October 27, 2022 05:30
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 27, 2022
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8cb5c97

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2022
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2022
@rleungx
Copy link
Member Author

rleungx commented Oct 27, 2022

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b983009

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed do-not-merge/needs-linked-issue labels Oct 27, 2022
@ti-chi-bot
Copy link
Member

@rleungx: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1e19335 into tikv:master Oct 27, 2022
@rleungx rleungx deleted the region-path branch October 27, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants