Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix the bug that balance-hot-region-scheduler does not store config when it starts #5702

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

HunDunDM
Copy link
Member

Signed-off-by: HunDunDM [email protected]

What problem does this PR solve?

Issue Number: Close #5701

What is changed and how does it work?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 75.65% // Head: 75.67% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b3716b3) compared to base (53cb66d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5702      +/-   ##
==========================================
+ Coverage   75.65%   75.67%   +0.01%     
==========================================
  Files         329      329              
  Lines       32681    32682       +1     
==========================================
+ Hits        24726    24731       +5     
+ Misses       5821     5817       -4     
  Partials     2134     2134              
Flag Coverage Δ
unittests 75.67% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 85.01% <100.00%> (+0.01%) ⬆️
server/storage/endpoint/rule.go 83.33% <0.00%> (-11.12%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-6.76%) ⬇️
server/tso/allocator_manager.go 61.93% <0.00%> (-3.88%) ⬇️
server/schedule/labeler/labeler.go 76.77% <0.00%> (-2.59%) ⬇️
server/cluster/coordinator.go 71.23% <0.00%> (-1.34%) ⬇️
tools/pd-ctl/pdctl/command/hot_command.go 71.03% <0.00%> (-0.69%) ⬇️
server/schedule/operator_controller.go 87.16% <0.00%> (-0.23%) ⬇️
client/client.go 67.45% <0.00%> (-0.11%) ⬇️
server/tso/tso.go 69.66% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HunDunDM HunDunDM requested review from lhy1024 and nolouch and removed request for disksing November 10, 2022 15:39
Signed-off-by: HunDunDM <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2022
@nolouch
Copy link
Contributor

nolouch commented Nov 11, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b3716b3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2022
@ti-chi-bot ti-chi-bot merged commit fcfcda3 into tikv:master Nov 11, 2022
@nolouch nolouch deleted the fix-5701 branch November 11, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The config is not persisted after the balance-hot-region-scheduler is started
4 participants