Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix lock in CheckAndPutRegion #5768

Merged
merged 1 commit into from
Dec 8, 2022
Merged

*: fix lock in CheckAndPutRegion #5768

merged 1 commit into from
Dec 8, 2022

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 8, 2022 •
edited
Loading

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Ref #5648.

What is changed and how does it work?

The problem is the same as the above issue and was introduced by #5615. This problem only exists in the master, no need to cherry-pick.

Check List

Tests

  • Unit test

Release note

None

@rleungx
fix lock
7d38d8e 
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

lhy1024
lhy1024 approved these changes Dec 8, 2022
View reviewed changes
server/core/region.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 8, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 8, 2022
@rleungx
Copy link
Member Author

rleungx commented Dec 8, 2022

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7d38d8e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 8, 2022
@rleungx
Copy link
Member Author

rleungx commented Dec 8, 2022

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot merged commit 8c5c666 into tikv:master Dec 8, 2022
@rleungx rleungx deleted the fix-lock2 branch December 8, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rleungx @ti-chi-bot @lhy1024 @CabinfeverB