client: both Support names and config path #5886

HuSharp · 2023-01-31T02:19:50Z

Signed-off-by: husharp [email protected]

What problem does this PR solve?

Issue Number: Close #5885, Ref #pingcap/tiflow#8110, should merged after #5887 #5888 and pingcap/kvproto#1051

What is changed and how does it work?

The global config needs to support both names and configuration paths, not only for compatibility but also to make more sense.

Check List

Tests

Unit test

Release note

None

codecov · 2023-01-31T02:27:15Z

Codecov Report

Base: 75.54% // Head: 75.72% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (93c4a2a) compared to base (abb62d2).
Patch coverage: 62.50% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5886      +/-   ##
==========================================
+ Coverage   75.54%   75.72%   +0.18%     
==========================================
  Files         343      343              
  Lines       34993    35021      +28     
==========================================
+ Hits        26434    26519      +85     
+ Misses       6275     6237      -38     
+ Partials     2284     2265      -19

Flag	Coverage Δ
unittests	`75.72% <62.50%> (+0.18%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
client/resourcemanager_client.go	`75.77% <ø> (ø)`
server/grpc_service.go	`49.19% <60.71%> (+0.26%)`	⬆️
client/client.go	`70.66% <66.66%> (-0.03%)`	⬇️
pkg/storage/endpoint/meta.go	`61.36% <0.00%> (-6.82%)`	⬇️
server/storage/storage.go	`67.30% <0.00%> (-3.85%)`	⬇️
server/region_syncer/client.go	`84.32% <0.00%> (-1.50%)`	⬇️
server/api/region.go	`68.09% <0.00%> (-1.43%)`	⬇️
server/schedule/region_scatterer.go	`77.86% <0.00%> (-1.19%)`	⬇️
server/schedule/operator_controller.go	`85.97% <0.00%> (-0.91%)`	⬇️
server/cluster/coordinator.go	`71.59% <0.00%> (-0.76%)`	⬇️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: husharp <[email protected]>

…anager (#5887) ref #5851, ref #5886, ref pingcap/tiflow#8110 Signed-off-by: Cabinfever_B <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>

Signed-off-by: husharp <[email protected]>

server/grpc_service.go

Signed-off-by: husharp <[email protected]>

glorv

LGTM

Signed-off-by: husharp <[email protected]>

HuSharp · 2023-02-02T01:52:11Z

@JmPotato @nolouch @CabinfeverB friendly ping, thx! :)

Signed-off-by: husharp <[email protected]>

YangKeao · 2023-02-02T04:12:33Z

/run-build-arm64

sre-bot · 2023-02-02T04:17:44Z

download pd binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/pd/68b5d80b943dea837ef44bdfc722cb37e7d1e99c/centos7/pd-linux-arm64.tar.gz

CabinfeverB

Rest LGTM

server/grpc_service.go

ti-chi-bot · 2023-02-02T05:43:48Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

CabinfeverB
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: husharp <[email protected]>

ti-chi-bot · 2023-02-02T06:59:28Z

@BornChanger: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

nolouch · 2023-02-02T08:44:29Z

/merge

ti-chi-bot · 2023-02-02T08:44:31Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-02-02T08:44:32Z

This pull request has been accepted and is ready to merge.

Commit hash: 9e839ec

HuSharp · 2023-02-02T08:54:25Z

/test

ti-chi-bot · 2023-02-02T08:54:39Z

@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-02-02T09:06:09Z

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

CabinfeverB · 2023-02-02T09:36:34Z

/ok-to-test

HuSharp · 2023-02-02T09:38:04Z

/test build

config support both path and names

dc6b06d

Signed-off-by: husharp <[email protected]>

HuSharp force-pushed the fix_cdc_compatible branch from f2d03fb to dc6b06d Compare January 31, 2023 02:29

config support both path and names

43bdd42

Signed-off-by: husharp <[email protected]>

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 31, 2023

HuSharp added 2 commits January 31, 2023 14:43

fix item value type

84ddbab

Signed-off-by: husharp <[email protected]>

update kvproto

cec9f48

Signed-off-by: husharp <[email protected]>

CabinfeverB mentioned this pull request Jan 31, 2023

resource_manager, storage: create new storage endpoint for resource manager #5887

Merged

rename

9e04a1b

Signed-off-by: husharp <[email protected]>

HuSharp added 2 commits February 1, 2023 15:22

merge upstream

18ed0d7

Signed-off-by: husharp <[email protected]>

merge upstream

cd4e572

Signed-off-by: husharp <[email protected]>

HuSharp mentioned this pull request Feb 1, 2023

update go version to 1.19 and config support both path and names tikv/client-go#683

Merged

HuSharp marked this pull request as ready for review February 1, 2023 07:44

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2023

CabinfeverB requested review from CabinfeverB, JmPotato and nolouch February 1, 2023 07:51

both pass through payload and value

3c17fe0

Signed-off-by: husharp <[email protected]>

JmPotato reviewed Feb 1, 2023

View reviewed changes

server/grpc_service.go Show resolved Hide resolved

server/grpc_service.go Show resolved Hide resolved

add some comment

b7fa891

Signed-off-by: husharp <[email protected]>

HuSharp mentioned this pull request Feb 1, 2023

pd_client: update client and global config pingcap/tidb#40955

Merged

glorv reviewed Feb 1, 2023

View reviewed changes

update kvproto

1217f01

Signed-off-by: husharp <[email protected]>

HuSharp added 2 commits February 2, 2023 11:13

refine comment

15d84c5

Signed-off-by: husharp <[email protected]>

refine comment

68b5d80

Signed-off-by: husharp <[email protected]>

CabinfeverB approved these changes Feb 2, 2023

View reviewed changes

server/grpc_service.go Show resolved Hide resolved

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2023

add comment

08bcb9f

Signed-off-by: husharp <[email protected]>

HuSharp force-pushed the fix_cdc_compatible branch from 31fb842 to 08bcb9f Compare February 2, 2023 06:37

Merge branch 'master' into fix_cdc_compatible

9e839ec

BornChanger approved these changes Feb 2, 2023

View reviewed changes

nolouch approved these changes Feb 2, 2023

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 2, 2023

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2023

Merge branch 'master' into fix_cdc_compatible

6f6d66d

Merge branch 'master' into fix_cdc_compatible

93c4a2a

ti-chi-bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 2, 2023

ti-chi-bot merged commit 18df271 into tikv:master Feb 2, 2023

HuSharp mentioned this pull request Feb 3, 2023

*(all): update dependencies on tidb and pd. pingcap/tiflow#8126

Merged

HuSharp deleted the fix_cdc_compatible branch March 10, 2023 05:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

client: both Support names and config path #5886

client: both Support names and config path #5886

HuSharp commented Jan 31, 2023 •

edited

Loading

codecov bot commented Jan 31, 2023 •

edited

Loading

glorv left a comment

HuSharp commented Feb 2, 2023

YangKeao commented Feb 2, 2023

sre-bot commented Feb 2, 2023

CabinfeverB left a comment

ti-chi-bot commented Feb 2, 2023 •

edited

Loading

ti-chi-bot commented Feb 2, 2023

nolouch commented Feb 2, 2023

ti-chi-bot commented Feb 2, 2023

ti-chi-bot commented Feb 2, 2023

HuSharp commented Feb 2, 2023

ti-chi-bot commented Feb 2, 2023

ti-chi-bot commented Feb 2, 2023

CabinfeverB commented Feb 2, 2023

HuSharp commented Feb 2, 2023

client: both Support names and config path #5886

client: both Support names and config path #5886

Conversation

HuSharp commented Jan 31, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

codecov bot commented Jan 31, 2023 • edited Loading

Codecov Report

glorv left a comment

Choose a reason for hiding this comment

HuSharp commented Feb 2, 2023

YangKeao commented Feb 2, 2023

sre-bot commented Feb 2, 2023

CabinfeverB left a comment

Choose a reason for hiding this comment

ti-chi-bot commented Feb 2, 2023 • edited Loading

ti-chi-bot commented Feb 2, 2023

nolouch commented Feb 2, 2023

ti-chi-bot commented Feb 2, 2023

ti-chi-bot commented Feb 2, 2023

HuSharp commented Feb 2, 2023

ti-chi-bot commented Feb 2, 2023

ti-chi-bot commented Feb 2, 2023

CabinfeverB commented Feb 2, 2023

HuSharp commented Feb 2, 2023

HuSharp commented Jan 31, 2023 •

edited

Loading

codecov bot commented Jan 31, 2023 •

edited

Loading

ti-chi-bot commented Feb 2, 2023 •

edited

Loading