-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdutil: support multi backends client #6046
Conversation
Signed-off-by: lhy1024 <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: lhy1024 <[email protected]>
Codecov ReportBase: 74.90% // Head: 74.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #6046 +/- ##
=======================================
Coverage 74.90% 74.90%
=======================================
Files 365 366 +1
Lines 36552 36562 +10
=======================================
+ Hits 27378 27388 +10
+ Misses 6786 6783 -3
- Partials 2388 2391 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: lhy1024 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the unresolved comment.
Signed-off-by: lhy1024 <[email protected]>
@@ -41,6 +38,9 @@ const ( | |||
// defaultEtcdClientTimeout is the default timeout for etcd client. | |||
defaultEtcdClientTimeout = 3 * time.Second | |||
|
|||
// defaultAutoSyncInterval is the interval to sync etcd cluster. | |||
defaultAutoSyncInterval = 60 * time.Second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, Is there some releationship between the timeouts, like defaultEtcdClientTimeout
,DefaultDialTimeout
,DefaultRequestTimeout
?
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: d8741ad
|
…sible (#6059) ref #6046, close #6053, ref #6059 Signed-off-by: lhy1024 <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>
What problem does this PR solve?
Issue Number: Close #6042
What is changed and how does it work?
Check List
Tests
Release note