-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: move statistics
, schedule
from server
to pkg
#6133
Conversation
Signed-off-by: HunDunDM <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6133 +/- ##
==========================================
- Coverage 74.50% 74.08% -0.42%
==========================================
Files 389 388 -1
Lines 38125 38061 -64
==========================================
- Hits 28404 28199 -205
- Misses 7210 7384 +174
+ Partials 2511 2478 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 27 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@@ -1,5 +1,5 @@ | |||
# Require review from domain experts when the PR modified significant config files. | |||
/server/config/config.go @tikv/pd-configuration-reviewer | |||
/server/schedule/schedulers/hot_region_config.go @tikv/pd-configuration-reviewer | |||
/pkg/schedule/schedulers/hot_region_config.go @tikv/pd-configuration-reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“This CODEOWNERS file contains errors”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is for migration only, no other changes.
/merge |
@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: d6e1e34
|
What problem does this PR solve?
Issue Number: Ref #5839
What is changed and how does it work?
*: move
statistics
,schedule
fromserver
topkg
Check List
Tests
Code changes
Side effects
Related changes
Release note