Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move statistics, schedule from server to pkg #6133

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

HunDunDM
Copy link
Member

@HunDunDM HunDunDM commented Mar 9, 2023

What problem does this PR solve?

Issue Number: Ref #5839

What is changed and how does it work?

*: move statistics, schedule from server to pkg

Check List

Tests

  • No code

Code changes

Side effects

Related changes

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.42 ⚠️

Comparison is base (2296562) 74.50% compared to head (73a69b5) 74.08%.

❗ Current head 73a69b5 differs from pull request most recent head d6e1e34. Consider uploading reports for the commit d6e1e34 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6133      +/-   ##
==========================================
- Coverage   74.50%   74.08%   -0.42%     
==========================================
  Files         389      388       -1     
  Lines       38125    38061      -64     
==========================================
- Hits        28404    28199     -205     
- Misses       7210     7384     +174     
+ Partials     2511     2478      -33     
Flag Coverage Δ
unittests 74.08% <ø> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/autoscaling/calculation.go 58.41% <ø> (ø)
pkg/mock/mockcluster/config.go 100.00% <ø> (ø)
pkg/mock/mockcluster/mockcluster.go 94.25% <ø> (ø)
pkg/mock/mockconfig/mockconfig.go 100.00% <ø> (ø)
pkg/mock/mockhbstream/mockhbstream.go 85.71% <ø> (ø)
pkg/schedule/checker/checker_controller.go 77.52% <ø> (ø)
pkg/schedule/checker/checker_pause.go 100.00% <ø> (ø)
pkg/schedule/checker/joint_state_checker.go 57.89% <ø> (ø)
pkg/schedule/checker/learner_checker.go 72.72% <ø> (ø)
pkg/schedule/checker/merge_checker.go 70.99% <ø> (ø)
... and 117 more

... and 27 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -1,5 +1,5 @@
# Require review from domain experts when the PR modified significant config files.
/server/config/config.go @tikv/pd-configuration-reviewer
/server/schedule/schedulers/hot_region_config.go @tikv/pd-configuration-reviewer
/pkg/schedule/schedulers/hot_region_config.go @tikv/pd-configuration-reviewer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“This CODEOWNERS file contains errors”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is for migration only, no other changes.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 10, 2023
@HunDunDM
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d6e1e34

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 10, 2023
@ti-chi-bot ti-chi-bot merged commit 6f6f545 into tikv:master Mar 10, 2023
@HunDunDM HunDunDM deleted the split-schedule/move branch March 10, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants