Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdutil: revert etcd client in pd legacy server #6182

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Mar 20, 2023

What problem does this PR solve?

Issue Number: Close #6124

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue labels Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 91.30% and project coverage change: -0.07 ⚠️

Comparison is base (220dbed) 74.53% compared to head (469ba03) 74.47%.

❗ Current head 469ba03 differs from pull request most recent head afa43ed. Consider uploading reports for the commit afa43ed to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6182      +/-   ##
==========================================
- Coverage   74.53%   74.47%   -0.07%     
==========================================
  Files         394      394              
  Lines       38644    38660      +16     
==========================================
- Hits        28804    28791      -13     
- Misses       7293     7314      +21     
- Partials     2547     2555       +8     
Flag Coverage Δ
unittests 74.47% <91.30%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mcs/tso/server/server.go 50.16% <ø> (ø)
pkg/utils/etcdutil/etcdutil.go 79.73% <90.47%> (+0.90%) ⬆️
pkg/mcs/resource_manager/server/server.go 57.32% <100.00%> (ø)
server/server.go 73.85% <100.00%> (-1.09%) ⬇️

... and 23 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 20, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 20, 2023
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
Copy link
Contributor Author

lhy1024 commented Mar 20, 2023

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 469ba03

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 20, 2023
@ti-chi-bot
Copy link
Member

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #6186.

@lhy1024 lhy1024 deleted the etcd3 branch March 20, 2023 14:42
ti-chi-bot added a commit that referenced this pull request Mar 21, 2023
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Mar 22, 2023
CabinfeverB pushed a commit to ti-chi-bot/pd that referenced this pull request Mar 22, 2023
CabinfeverB pushed a commit to ti-chi-bot/pd that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.0 release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qps dorp to zero after inject pdleader io hang
4 participants